Messages in this thread Patch in this message | | | Date | Fri, 23 Jan 2004 21:05:20 +0100 | From | Jean Delvare <> | Subject | Message about PCILynx in kernel config |
| |
Hi all,
This is a proposed patch to alter the conditions under which the PCILynx message is displayed while configuring Linux 2.6. The way it is now, a user with PCI and I2C both disabled will see a message stating that "PCILynx requires I2C". If the user goes to the I2C section and selects I2C, then comes back to the IEEE 1394 section, the message will have disappeared (because I2C isn't missing anymore) but the PCILynx option will not show (because PCI is still not selected).
I think it might be confusing, so I suggest that the message shouldn't be displayed at all if PCI isn't selected. And here's a simple patch that does just this. Built against and tested on Linux 2.6.2-rc1.
Thanks for your attention.
--- linux-2.6.2-rc1/drivers/ieee1394/Kconfig.orig 2004-01-22 10:37:43 +0100 +++ linux-2.6.2-rc1/drivers/ieee1394/Kconfig 2004-01-22 10:43:10 +0100 @@ -52,7 +52,7 @@ depends on IEEE1394 comment "Texas Instruments PCILynx requires I2C" - depends on IEEE1394 && I2C=n + depends on PCI && IEEE1394 && I2C=n config IEEE1394_PCILYNX tristate "Texas Instruments PCILynx support"
-- Jean Delvare http://www.ensicaen.ismra.fr/~delvare/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |