lkml.org 
[lkml]   [2004]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] Move bv_offset/bv_len update after bio_endio in __end_that_request_first
On Fri, Jan 02 2004, Christophe Saout wrote:
> Am Fr, den 02.01.2004 schrieb Jens Axboe um 11:46:
>
> > > That's why I need to know exactly how many and which bvecs were completed
> > > in my bi_end_io function.
> > >
> > > Or do you think it is safer to count backwards using bi_vcnt and bi_size?
> >
> > I'm inclined to thinking that, indeed. Those two fields have a more well
> > established usage, so I think you'll be better off doing that in the
> > long run.
>
> Ok, if you say so. This and the IDE multwrite thing are the only two
> places in the kernel preventing bi_idx to be usable this way. I just
> thought it was nicer.

It is nicer, I agree. I'm not adverse to including the ll_rw_blk change,
you'll have to deal with IDE yourself :)

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.049 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site