Messages in this thread | | | Date | Mon, 19 Jan 2004 13:41:38 -0800 | From | Greg KH <> | Subject | Re: calling pci_find_device in interrupt ? |
| |
On Mon, Jan 19, 2004 at 03:15:31PM -0600, linas@austin.ibm.com wrote: > > Greg,
Hm, this isn't really a hotplug question. This is better asked on linux-kernel.
> I was calling pci_find_device() from an interrupt, when I discovered > that it has a WARN_ON(in_interrupt()); in it. > > Why? If spin_lock(&pci_bus_lock); was changed to spin_lock_irqsave(), > it seems like it would be interrupt-safe.
Because you should not call such a function from an interrupt. It is a waste of time. Just save off your pci device structure properly in your setup functions.
Also, don't use the pci_find_* functions. Use the pci_get_* functions instead, as the pci_find_* functions will be going away in a future kernel version (probably 2.7).
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |