![]() | ||||||||||
Messages in this thread |
On Sunday 18 of January 2004 12:52, Arkadiusz Miskiewicz wrote: > Dnia sob 17. stycznia 2004 17:02, Bartlomiej Zolnierkiewicz napisał: > > On Saturday 17 of January 2004 16:38, Sam Ravnborg wrote: > > > > +ide-core-objs += ide.o ide-default.o ide-io.o ide-iops.o ide-lib.o \ > > > > + ide-probe.o ide-taskfile.o > > > > > > It would be more consistent to use "ide-core-y" since this is > > > what the following lines are expanded to. > > > > > > > + > > > > +ide-core-$(CONFIG_BLK_DEV_CMD640) += pci/cmd640.o > > > > > > Like this line. > > > > Yep, thanks! > > Could you send updated patch so we could test it? > > Also would be nice if ide-detect name was used instead of ide-generic so it > will be consistent with 2.4 naming. ide-detect != ide-generic In 2.4 you have to load ide-detect after loading chipset module. In 2.6+patch you don't have to load anything after loading chipset module. ide-detect is used for all chipset modules to probe for drives. ide-generic is generic/default host driver - you use it only if you don't have specific modules for your IDE chipsets. > ps. patch by Witold Krecicki works for other drivers - I've seen it working > - but it's hacky anyway. Sure, it works for other *PCI* drivers, but not ie. PPC ones (easy to fix). --bart - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2005-03-22 13:00 [from the cache] ©2003-2008 | ||||||||||