lkml.org 
[lkml]   [2004]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Help port swsusp to ppc.
From
Date
Hi !

Some comments...

>Index: arch/ppc/kernel/swsusp2-asm.S
>===================================================================
>--- arch/ppc/kernel/swsusp2-asm.S (revision 0)
>+++ arch/ppc/kernel/swsusp2-asm.S (revision 0)


What is this file ? It's absolutely horrible....

>Index: arch/ppc/kernel/Makefile
>===================================================================
>--- arch/ppc/kernel/Makefile (revision 192)
>+++ arch/ppc/kernel/Makefile (working copy)
>@@ -34,3 +34,5 @@
> obj-$(CONFIG_8xx) += softemu8xx.o
> endif
>
>+obj-$(CONFIG_SOFTWARE_SUSPEND2) += swsusp2-asm.o
>+obj-$(CONFIG_SOFTWARE_SUSPEND2) += ppc_reg.o

You could have put both of these on the same line.


>Index: arch/ppc/kernel/vmlinux.lds.S
>===================================================================
>--- arch/ppc/kernel/vmlinux.lds.S (revision 192)
>+++ arch/ppc/kernel/vmlinux.lds.S (working copy)
>@@ -72,6 +72,12 @@
> CONSTRUCTORS
> }
>
>+ . = ALIGN(4096);
>+ __nosave_begin = .;
>+ .data_nosave : { *(.data.nosave) }
>+ . = ALIGN(4096);
>+ __nosave_end = .;
>+
> . = ALIGN(32);
> .data.cacheline_aligned : { *(.data.cacheline_aligned) }

Why do you need the above for ?



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:00    [from the cache]
©2003-2011 Jasper Spaans