![]() | |||||||||||||
Messages in this thread |
On Sat, Jan 17, 2004 at 09:55:45AM -0500, Joe Korty wrote: > > > + bitmap_clear(maskp, nmaskbits); > > > > Might be better to clear all the bits in the mask, > > not just the low order nmaskbits worth. > > Thanks. Will do. > Joe Hi Paul, On reflection, I reverse my position -- this should really be done in bitmap_clear et all as an attribute of bitmaps in general, rather than as something local to bitmap_parse. Right now, the bitmap functions treat the unused bits as a kind of garbage dump. For example, bitmap_complement() flips every bit in the set of unsigned longs. Therefore it is somewhat meaningless for bitmap_parse, alone among the bitmap functions, to treat the unused bits as something special. -- Joe "Money can buy bandwidth, but latency is forever" -- John Mashey - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:00 [from the cache] ©2003-2008 | |||||||||||||