lkml.org 
[lkml]   [2004]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Newbie-warning] MOD_INC_USE_COUNT usage
From
Date
On Wed, 2004-01-14 at 21:25, Krzysztof Halasa wrote:
> Tim Cambrant <tim@cambrant.com> writes:
>
> > So, why shouldn't this patch be applied?:
> >
> > --- drivers/ide/pci/generic.c.orig 2004-01-14 17:52:35.000000000 +0100
> > +++ drivers/ide/pci/generic.c 2003-11-24 13:54:01.000000000 +0100
> > @@ -121,6 +121,7 @@ static int __devinit generic_init_one(st
> > return 1;
> > }
> > ide_setup_pci_device(dev, d);
> > + MOD_INC_USE_COUNT;
> > return 0;
> > }
>
> It isn't that easy - the module must be marked as being in use this
> way or (preferably) another.

Hello,

As I can see, this is really redundant to have a MOD_INC_USE_COUNT for
almost all the modules. But this should be checked carefully before
removing ;)


--
umka

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:00    [W:0.070 / U:0.488 seconds]
©2003-2014 Jasper Spaans. Advertise on this site