Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH][RFC] 2.6 && module + -g && kernel w/o -g | Date | Thu, 15 Jan 2004 10:00:11 +1100 |
| |
In message <20040114210937.GA983@stop.crashing.org> you write: > Okay. I've been looking at stock 2.6.1 noticed that the fix for this > issue that Rusty proposed, and that ultimately made it into 2.6.1-rc3 > (or so) is not correct. The problem is that we do: > > err = module_frob_arch_sections(hdr, sechdrs, secstrings, mod); > /* Which goes over every .debug section and can take _ages_ on something > * like ipv6 */
Right. So the arch-specific module_frob_arch_sections() can be slow. Logically, the fix should be in those module_frob_arch_sections(), not in the generic code.
> + /* If we find any debug RELAs, frob these away now. */ > + if (sechdrs[i].sh_type == SHT_RELA && > + (strstr(secstrings+sechdrs[i].sh_name, ".debug") > + != 0)) > + sechdrs[i].sh_type = SHT_NULL; > +
Doesn't cover SHT_REL, and I really dislike name matches: they've bitten us before.
Really, I prefer the arch-specific optimization. Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |