Messages in this thread | | | Date | Tue, 13 Jan 2004 18:29:55 +0000 | From | Russell King <> | Subject | Re: Re: [PROBLEM] ircomm ioctls |
| |
On Tue, Jan 13, 2004 at 10:10:34AM -0800, Jean Tourrilhes wrote: > Russell King wrote : > > On Tue, Jan 13, 2004 at 12:00:15PM +0100, Jozef Vesely wrote: > > > I am gettig this error (while connecting to my mobile phone): > > > ------ > > > # gsmctl -d /dev/ircomm0 ALL > > > gsmctl[ERROR]: clearing DTR failed (errno: 22/Invalid argument) > > > ------ > > > > ircomm needs updating to use the tiocmset/tiocmget driver calls. Could > > you see if the following patch solves your problem please? > > Good catch. Is there any other API changes worth looking into ? > > By the way, I would rather keep the function > ircomm_tty_tiocmget() and ircomm_tty_tiocmset() in ircomm_tty_ioctl.c, > because ircomm_tty.c is already big and messy. > Check the patch below (quickly tested).
I think this patch is missing some of the error checking (TTY_IO_ERROR) which I included in my later patch.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |