lkml.org 
[lkml]   [2004]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rfc/patch] wake_up_info() draft ...
Hi Davide,

I think the patch adds unnecessary bloat, and mandates one particular
use of the wait queue info interface.
For example, why does remove_wait_queue_info copy the wakeup info
around? That's now how I would use it for fasync: I would send the
necessary signals directly from the wakeup handler, and
remove_wait_queue_info is called during sys_close handling, info discarded.

I'm thinking about a simpler approach: add a wake_up_info() function,
and forward the info parameter to the wait_queue_func_t. This means
changing the prototype of this function - there shouldn't be that many
instances. NULL is passed if the normal wake_up functions are used. No
additional fields in the wait queue entry are required. Then I would
convert kill_fasync to that interface, with the band value from
kill_fasync as the info parameter. A custom wait queue func does the
signal sending. fasync_helper would be kmalloc+add_wait_queue.

--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.044 / U:0.296 seconds]
©2003-2014 Jasper Spaans. Advertise on this site