lkml.org 
[lkml]   [2003]   [Sep]   [4]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 4 Sep 2003 08:30:07 +0100
FromRussell King <>
SubjectRe: [PATCH] fix ppc ioremap prototype
On Thu, Sep 04, 2003 at 09:13:34AM +0200, Christoph Hellwig wrote:
> On Thu, Sep 04, 2003 at 10:33:57AM +1000, Paul Mackerras wrote:
> > I don't see why this is a problem.  The change is compatible with the
> > existing uses.  We need to be able to map 36-bit physical addresses on
> > 44x.  What we really need now is 64-bit start/end values in struct
> > resource.
> 
> Then add the phys_addr_t to all places where we deal with physical
> addresses, even if it's typedef'ed to unsigned long on all other
> arches and sane ppcs.

But phys_addr_t in struct resource and being passed into ioremap is
confusing.  Apparantly, it isn't a physical address, but a platform
defined cookie which just happens to look like a physical address.

(or are we finally going to admit that it is a physical address?)

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [from the cache]
©2003-2008