Messages in this thread | | | Subject | RE: [PATCH] linux-2.6.0-test4_cyclone-hpet-fix_A0 | From | john stultz <> | Date | 04 Sep 2003 10:53:50 -0700 |
| |
On Thu, 2003-09-04 at 10:21, Pallipadi, Venkatesh wrote:
> > Can we not we avoid the cut-n-paste coding? > > > > There is also timer_tsc.c:calibrate_tsc_hpet() which is > > almost the same as > > timer_hpet.c:calibrate_tsc(). Seem to me that we could tweak > > calibrate_tsc_hpet() a bit, unstaticalise > > timer_tsc.c:calibrate_tsc() and > > have two functions rather than four? > > > > > How about the attached patch (against mm4), that moves all > calibrate tsc functions into a common file, avoiding the duplication. > This time I could successfully compile cyclone timer too :). However,
Looks better, any reason calibrate_tsc and calibrate_tsc_hpet can't be unified (it looks like the same basic code just talking to different hardware)? I was planning on giving that a shot later today.
> I had to do an unrelated one line change in fixmap (last chunk in > the patch) to compile for summit.
Is this just an -mm only thing (2.5 has _X86_CYCLONE_TIMER everywhere)?
thanks -john
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |