Messages in this thread Patch in this message | | | From | Benjamin Herrenschmidt <> | Date | Wed, 03 Sep 2003 18:17:43 +0200 | Subject | Re: [PATCH] IDE: Enable LED support for PowerMac |
| |
On Wed, 2003-09-03 at 18:14, Benjamin Herrenschmidt wrote: > Hi Bart ! > > Please submit that to Linus. It adds the Kconfig option for the > PowerMac IDE driver "LED" feature (using the laptop's front LED > as a disk activity indicator). It also adds a small bit to ide-probe.c > that was missing from Jens patch when he added the activity function > infrastructure. He did add the hwif field, but not the code to actually > enable it.
OOOps, the patch had additional crap appended to it, here's a cleaned up version, sorry:
diff -urN for-linus-ppc/drivers/ide/Kconfig linuxppc-2.5-benh/drivers/ide/Kconfig --- for-linus-ppc/drivers/ide/Kconfig 2003-09-03 18:07:14.000000000 +0200 +++ linuxppc-2.5-benh/drivers/ide/Kconfig 2003-08-25 22:04:14.000000000 +0200 @@ -835,6 +835,13 @@ to transfer data to and from memory. Saying Y is safe and improves performance. +config BLK_DEV_IDE_PMAC_BLINK + bool "Blink laptop LED on drive activity" + depends on BLK_DEV_IDE_PMAC && ADB_PMU + help + This option enables the use of the sleep LED as a hard drive + activity LED. + config BLK_DEV_IDEDMA_PMAC_AUTO bool "Use DMA by default" depends on BLK_DEV_IDEDMA_PMAC diff -urN for-linus-ppc/drivers/ide/ide-probe.c linuxppc-2.5-benh/drivers/ide/ide-probe.c --- for-linus-ppc/drivers/ide/ide-probe.c 2003-09-03 18:07:14.000000000 +0200 +++ linuxppc-2.5-benh/drivers/ide/ide-probe.c 2003-09-03 18:05:12.000000000 +0200 @@ -958,6 +958,10 @@ /* needs drive->queue to be set */ ide_toggle_bounce(drive, 1); + /* enable led activity for disk drives only */ + if (drive->media == ide_disk && hwif->led_act) + blk_queue_activity_fn(q, hwif->led_act, drive); + return 0; }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |