lkml.org 
[lkml]   [2003]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Linux 2.6.0-test6
    On Sun, 28 Sep 2003, Russell King wrote:
    > On Sun, Sep 28, 2003 at 10:37:36AM -0700, Linus Torvalds wrote:
    > > On Sun, 28 Sep 2003, Geert Uytterhoeven wrote:
    > > > On Sat, 27 Sep 2003, Linus Torvalds wrote:
    > > > > Bernardo Innocenti:
    > > > > o GCC 3.3.x/3.4 compatiblity fix in include/linux/init.h
    > > >
    > > > This change breaks 2.95 for some source files, because <linux/init.h> doesn't
    > > > include <linux/compiler.h>. Do you want to have the missing include added to
    > > > <linux/init.h>, or to the individual source files that need it?
    > >
    > > Interesting. I'm pretty sure I did a "make allyesconfig" just before the
    > > test6 release, so apparently x86 includes it indirectly through some path,
    > > and so it only shows up on m68k and arm?
    > >
    > > This, btw, is a pretty common thing. I wonder what we could do to make
    > > sure that different architectures wouldn't have so different include file
    > > structures. It's happened _way_ too often.
    > >
    > > Any ideas?
    >
    > The two files that it showed up in on ARM are fairly simple in nature and
    > don't include may headers. Making the ARM include structure identical to
    > x86 wouldn't have removed the problem from ARM.

    Same for m68k. The offender was a m68k-specific file (arch/m68k/sun3/sbus.c),
    which just included <linux/types.h> and <linux/init.h>, and uses
    subsys_initcall().

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:48    [W:0.029 / U:119.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site