![]() | |||||||||||||
Messages in this thread |
Hi, in nfs_writepage_sync in fs/nfs/write.c I see:
result = NFS_PROTO(inode)->write(inode, cred,
&fattr, flags,
offset, wsize,
page, &verf);
if (result < 0) {
/* Must mark the page invalid after I/O
error */
ClearPageUptodate(page);
goto io_error;
}
if (result != wsize)
printk("NFS: short write, wsize=%u,
result=%d\n",
wsize, result);
refresh = 1;
buffer += wsize;
base += wsize;
offset += wsize;
written += wsize;
count -= wsize;
Shouldn't buffer, base, offset, written, and count be
(inc|dec)remented by result instead of wsize?
This is with the latest CVS version of 2.5, but the
identical code is in Red Hat's 2.4.20-20.9.
-Kenny
__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
| ||||||||||||
| Last update: 2005-03-22 13:48 [from the cache] ©2003-2008 | |||||||||||||