Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] sysctl-controlled number of groups. | Date | Thu, 25 Sep 2003 18:17:30 +1000 |
| |
In message <20030924211417.A16753@hockin.org> you write: > On Thu, Sep 25, 2003 at 01:21:01PM +1000, Rusty Russell wrote: > > We have a client (using SAMBA) who has people in 190 groups. Since NT > > has hierarchical groups, this is not all that rare. > > > > What do people think of this patch? > > Excuse me but JESUS FUCKING CHRIST. I've been sending that patch since last > year.
Yes, I saw this (google sent me to a much older version when I looked, but I just found your more recent one).
I like the fact that you have no internal array, but I like the fact that I preserve the raw groups pointer. You go furthur and try to do better than linear search, too, I was aiming for minimalism.
> No sysctl - I didn't think it was needed at all.
Perhaps, but I was being cautious. With the default setting, it's identical to the current situation.
Cheers, Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |