lkml.org 
[lkml]   [2003]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [CHECKER] 32 Memory Leaks on Error Paths
    > > -	spin_lock(&codec->ac97_lock);
    > > + down(&unit->ac97_lock);
    > > /* XXX Do make use of dev->id */
    > > - ymfpci_codec_ready(codec, 0, 0);
    >
    > This breaks ac97 locking and should not be applied. The core ac97
    > code is called some times with interrupts disabled. That is unavoidable.
    >
    > The only change that is relevant is the kfree

    In that case, whoever added spinlocks should have removed
    schedule() from ymfpci_ready_wait().

    -- Pete
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:48    [W:0.056 / U:273.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site