Messages in this thread | | | Date | Mon, 22 Sep 2003 23:44:19 +0200 | From | Vojtech Pavlik <> | Subject | Re: 2.6.0-test5-mm4 |
| |
On Mon, Sep 22, 2003 at 11:55:09AM -0700, Andrew Morton wrote: > Zilvinas Valinskas <zilvinas@gemtek.lt> wrote: > > > > Btw Andrew , > > > > this change "Synaptics" -> "SynPS/2" - breaks driver synaptic driver > > from http://w1.894.telia.com/~u89404340/touchpad/index.html. > > > > > > -static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/ > > 2", "ImPS/2", "ImExPS/2", "Synaptics"}; > > +static char *psmouse_protocols[] = { "None", "PS/2", "PS2++", "PS2T++", "GenPS/2", "ImPS/2", "ImExPS/2", "SynPS/2"}; > > You mean it breaks the XFree driver? Is it just a matter of editing > XF86Config to tell it the new protocl name?
Ouch? This is just an information string, it is not supposed to be used anywhere except printks etc ... I really HOPE nobody is parsing these strings.
Before the patch, the input_dev.name string said
"Synaptics Synaptics Pad", which kind of didn't make much sense.
Since it's a concatenation of protocol, vendor and device names, it now says
"SynPS/2 Synaptics Pad", which sounds a bit better.
> Either way, it looks like a change which should be reverted?
If it breaks anything, that needs to be fixed in what it broke, because nothing should depend on this. If it does, then that's a big bug.
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |