Messages in this thread Patch in this message | | | Date | Sun, 21 Sep 2003 10:54:30 +0300 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH] move some more intilization out of drivers/char/mem.c |
| |
On Sat, Sep 20, 2003 at 11:48:53PM -0700, Andrew Morton wrote: > Christoph Hellwig <hch@lst.de> wrote: > > > > > Please compile-test things... > > > > Well, I compiled this here. I see, looks like I lost half of the patch > > when sending it to you. Sorryh for that, here's the full patch: > > It still generates warnings. I suggest you build kernels with a script > which saves up stderr and spits it all out at the end. That way, these > things are noticed.
This might be a good time to recommend -Werror. Last time it came up (http://marc.theaimsgroup.com/?l=linux-kernel&m=102654562025374&w=2), Alan was dead set against it, and Linus did not apply it, but did think it had some merit (http://marc.theaimsgroup.com/?l=linux-kernel&m=102658611213914&w=2).
Compiling 2.6.0-t5-cvs with my .config and -Werror uncovered only two warnings. Patches sent seperately.
diff --exclude-from /home/muli/p/dontdiff -Naur ../linux-2.5/Makefile 2.6.0-t5-Werror/Makefile --- ../linux-2.5/Makefile Wed Sep 10 16:21:16 2003 +++ 2.6.0-t5-Werror/Makefile Sun Sep 21 09:59:29 2003 @@ -73,7 +73,7 @@ HOSTCC = gcc HOSTCXX = g++ -HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer +HOSTCFLAGS = -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer HOSTCXXFLAGS = -O2 @@ -223,8 +223,8 @@ NOSTDINC_FLAGS = -nostdinc -iwithprefix include CPPFLAGS := -D__KERNEL__ -Iinclude -CFLAGS := -Wall -Wstrict-prototypes -Wno-trigraphs -O2 \ - -fno-strict-aliasing -fno-common +CFLAGS := -Wall -Werror -Wstrict-prototypes -Wno-trigraphs \ + -O2 -fno-strict-aliasing -fno-common AFLAGS := -D__ASSEMBLY__ export VERSION PATCHLEVEL SUBLEVEL EXTRAVERSION KERNELRELEASE ARCH \ -- Muli Ben-Yehuda http://www.mulix.org
[unhandled content-type:application/pgp-signature] | |