Messages in this thread | | | Date | Tue, 2 Sep 2003 22:20:56 +0100 | From | Jamie Lokier <> | Subject | Re: [PATCH 2/2] Futex non-page-pinning fix |
| |
Andrew Morton wrote: > Jamie Lokier <jamie@shareable.org> wrote: > > > > 3. For (vma & VM_SHARED), look up futex_qs keyed on > > (vma->vm_file, vma->vm_pgoff + (uaddr - vma->vm_start) >> > > PAGE_SHIFT, offset). > > That's a bit meaningless in non-linear mappings.
You think it's worth supporting futexes on non-linear mappings? I see your point of view; they could be useful.
In that case, the (vma & VM_SHARED) case needs to look up the correct pgoff or page after all.
It might be worth a VM_NONLINEAR flag, to skip walking the page table in the non-linear case, but that's just an optimisation.
-- Jamie
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |