Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] kernel/futex.c: Uneeded memory barrier | Date | Sun, 14 Sep 2003 21:39:01 +1000 |
| |
In message <3F620E61.4080604@terra.com.br> you write: > Kills an unneeded set_current_state after schedule_timeout, since it > already guarantees that the task will be TASK_RUNNING.
I thought we already got rid of that once: damn thing won't die...
> Also, when setting the state to TASK_RUNNING, isn't that memory > barrier unneeded? Patch removes this memory barrier too.
I personally *HATE* the set_task_state()/__set_task_state() macros. Simple assignments shouldn't be hidden behind macros, unless there's something really subtle involved.
Personally, when there's a normal and a __ version of a function, I use the normal version unless there's a real (performance or correctness) reason. (ie. I prefer the "think less" version 8).
I don't mind either way. I'll roll it in the next update.
Cheers, Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |