lkml.org 
[lkml]   [2003]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: Linux 2.4.23-pre4: failed at atyfb_base.c
    On Sat, 13 Sep 2003, Eyal Lebedinsky wrote:
    > Marcelo Tosatti wrote:
    > > Here goes -pre4, which contains networking update, IA64 update, PPC
    > > update, USB update, bunch of knfsd fixes, amongst others.
    > gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre/include -Wall
    > -Wstrict-pro
    > totypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
    > -fomit-frame-pointer
    > -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4
    > -DMODULE -DM
    > ODVERSIONS -include
    > /data2/usr/local/src/linux-2.4-pre/include/linux/modversions
    > .h -nostdinc -iwithprefix include -DKBUILD_BASENAME=atyfb_base
    > -DEXPORT_SYMTAB
    > -c atyfb_base.c
    > atyfb_base.c: In function `aty_set_crtc':
    > atyfb_base.c:501: warning: passing arg 2 of `aty_st_lcd' makes integer
    > from pointer without a cast
    > atyfb_base.c:501: too few arguments to function `aty_st_lcd'
    > atyfb_base.c:504: warning: passing arg 2 of `aty_st_lcd' makes integer
    > from pointer without a cast
    > atyfb_base.c:504: too few arguments to function `aty_st_lcd'
    > make[3]: *** [atyfb_base.o] Error 1
    > make[3]: Leaving directory
    > `/data2/usr/local/src/linux-2.4-pre/drivers/video/aty'
    >
    > I now disabled CONFIG_FB_ATY_GENERIC_LCD and it builds.

    Apparently Daniël didn't sent the latest version to Marcelo?

    Here are some fixes:

    --- linux-2.4.23-pre4/drivers/video/aty/atyfb_base.c.orig Sat Sep 13 16:29:48 2003
    +++ linux-2.4.23-pre4/drivers/video/aty/atyfb_base.c Fri Sep 12 12:50:36 2003
    @@ -313,7 +313,7 @@
    int pll, mclk, xclk;
    u32 features;
    } aty_chips[] __initdata = {
    - /* Note to kernel maintainers: Please resfuse any patch to change a clock rate,
    + /* Note to kernel maintainers: Please REFUSE any patch to change a clock rate,
    unless someone proves that a value is incorrect for him with a dump of
    the driver information table in the BIOS. Patches accepted in the past have
    caused chips to be overclocked by as much as 50%!
    @@ -498,10 +498,12 @@
    * off. It is a Rage Mobility M1, but doesn't happen on these chips
    * in general. (Daniel Mantione, 26 june 2003)
    */
    - aty_st_lcd(aty_ld_lcd(LCD_GEN_CTRL, info) | SHADOW_RW_EN, info);
    + aty_st_lcd(LCD_GEN_CTRL, aty_ld_lcd(LCD_GEN_CTRL, info) | SHADOW_RW_EN,
    + info);
    aty_st_le32(CRTC_H_TOTAL_DISP, crtc->h_tot_disp, info);
    aty_st_le32(CRTC_H_SYNC_STRT_WID, crtc->h_sync_strt_wid, info);
    - aty_st_lcd(aty_ld_lcd(LCD_GEN_CTRL, info) & ~SHADOW_RW_EN, info);
    + aty_st_lcd(LCD_GEN_CTRL, aty_ld_lcd(LCD_GEN_CTRL, info) & ~SHADOW_RW_EN,
    + info);
    /* End hack */
    #endif

    Gr{oetje,eeting}s,
    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:48    [W:0.024 / U:0.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site