lkml.org 
[lkml]   [2003]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Jiffies_64 for 2.4.22-ac
    On Fri, 12 Sep 2003, Tabris wrote:

    > I took Tim Schmielau's jiffies_64 patch, and ported it to -ac
    >
    > currently running on my machine here.
    > comments? did i screw up horribly?

    see my comments below:


    > +#define get_uidle_64() get_64bits(&(init_tasks[0]->times.tms_utime),\
    > + &uidle_msb_flips)
    > +#define get_sidle_64() get_64bits(&(init_tasks[0]->times.tms_stime),\
    > + &sidle_msb_flips)

    for -ac this needs to be

    +#define get_uidle_64() get_64bits(&(init_task.times.tms_utime),\
    + &uidle_msb_flips)
    +#define get_sidle_64() get_64bits(&(init_task.times.tms_stime),\
    + &sidle_msb_flips)


    > + check_one(init_tasks[0]->times.tms_utime, &uidle_msb_flips);
    > + check_one(init_tasks[0]->times.tms_stime, &sidle_msb_flips);

    ditto


    +#define get_uidle_64() (init_tasks[0]->times.tms_utime)
    +#define get_sidle_64() (init_tasks[0]->times.tms_stime)

    ditto


    > - unsigned long uptime;
    > - unsigned long idle;
    > + u64 uptime, idle;
    > int len;

    the declaration
    unsigned long uptime_remainder, idle_remainder;
    is missing


    > #if HZ!=100
    > len = sprintf(page,"%lu.%02lu %lu.%02lu\n",
    > - uptime / HZ,
    > - (((uptime % HZ) * 100) / HZ) % 100,
    > - idle / HZ,
    > - (((idle % HZ) * 100) / HZ) % 100);
    > + (unsigned long) uptime,
    > + uptime_remainder,
    > + (unsigned long) idle / HZ,
    > + idle_remainder);

    since we're in the HZ!=100 branch, this needs to be

    + (uptime_remainder * 100) / HZ,
    + (unsigned long) idle,
    + (idle_remainder * 100) / HZ);



    I wonder it actually compiled, but otherwise it looks good.

    Tim

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:48    [W:0.020 / U:0.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site