Messages in this thread | | | From | Neil Brown <> | Date | Fri, 12 Sep 2003 12:40:39 +1000 | Subject | Re: [2.6 patch] fix nfs4xdr.c compile warning |
| |
On Tuesday September 9, bunk@fs.tum.de wrote: > CC fs/nfsd/nfs4xdr.o > fs/nfsd/nfs4xdr.c: In function `nfsd4_encode_open': > fs/nfsd/nfs4xdr.c:1773: warning: `return' with a value, in function returning void > ... > > <-- snip --> > > > The following patch tries to fix it:
Thanks, though I've actually taken a different patch by Stephen Hemminger <shemminger@osdl.org>. > > BTW: > Shouldn't the return values of nfsd4_encode_open{,_confirm,_downgrade} > be checked in the switch in nfsd4_encode_operation?
No. There is nothing meaningful in their return values.
NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |