lkml.org 
[lkml]   [2003]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] s390 (6/7): network drivers.
Martin Schwidefsky wrote:

> - spin_lock_init(&card->wait_q_lock);
> + /* setup net_device stuff */
> + card->dev->priv = card;
> +
> + strncpy(card->dev->name, card->dev_name, IFNAMSIZ);

what's this about? Why avoid the net stack's dev->name assignment?



> + QETH_DBF_TEXT3(0, trace, "alloccrd");
> + card = (struct qeth_card *) vmalloc(sizeof (struct qeth_card));
> + if (!card)
> + return NULL;

Is the card's private info really so large that you need vmalloc() ?

Most of the patch looks ok to me, except for these minor niggles.

Jeff





-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site