Messages in this thread | | | Date | Wed, 10 Sep 2003 16:20:31 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] oops_in_progress is unlikely() |
| |
Hi!
> > Andrew - thanks for applying my last patch; thought you might be interested > > in this trivial one too. Patch is versus 2.6.0-test4-bk8, I expect it > > will also apply against current -mm. > > none of this patch seems to touch particularly performance critical code. > Is it really worth adding these macros to every if statement in the kernel? > There comes a point where readability is lost, for no measurable gain.
Perhaps we should have macros ifu() and ifl(), that would be used as a plain if, just with likelyness-indication? That way we could have it in *every* statement and readability would not suffer that much...
-- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |