Messages in this thread | | | Date | Mon, 1 Sep 2003 11:33:45 +0200 | From | Pavel Machek <> | Subject | Re: Fix up power managment in 2.6 |
| |
Hi!
> > Its the only way to have power managment working by 2.6.1. > > Rubbish. PM is now working here on ARM again - within a week of Pat's > change.
As you said, you are not using kernel/power.
> > Lots of > > work went into pm during 2.5 series, and Patrick invalidated all that > > with one, 140KB, untested and broken patch (and he managed to break > > about all rules about patch submission). > > I agree that it needed public review _before_ hitting Linus' tree - a > change of that magnitude with only half the subsystems fixed up should > not go directly into Linus' tree without review.
Good. [I believe it was big enough to require testing on separate tree (-mm? -ac?) before going mainline].
> > It is not possible to fix damage he done within week. > > It is my understanding that the old PM in 2.5 was not suitable for > the PPC architecture and the new PM model is. As far as the drivers > are concerned, the interface presented is a definite improvement on > what there was before (there are a few things which I'd like to see > further improvement on, but that's not a subject for discussion in > this thread.)
I only see dm getting more and more complicated :-(.
> I don't particularly care about kernel/power/* because its not useful > for me - whereas you obviously do. Maybe that's where your axe is > grinding. But whatever, don't throw the baby (driver model changes) > out with the bath water.
kernel/power/* changes are worst, because that's subsystem I should be maintainer of. Driver model changes are quite bad, too, because they mean we should go over all drivers and fix them. And driver failures are often pretty subtle.
> And finally, there's longer than a week to fix it. 8)
I'm not looking forward to another half-a-year before kernel gets into state where it was in -test3.
I still want that crap killed, at least because of the way *how* it was merged. Altrough killing kernel/power/* would be good start, and maybe it would lead us to a state where dm changes can be debugged.
Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |