Messages in this thread | | | Date | Sat, 9 Aug 2003 03:04:22 +0200 | Subject | Re: [PATCH] Change all occurrences of 'flavour' to 'flavor' | From | Trond Myklebust <> |
| |
>>>>> " " == Linus Torvalds <torvalds@osdl.org> writes:
> On 9 Aug 2003, Trond Myklebust wrote: >> >> Since we appear to be in the silly season...
> No, your patch isn't silly, it's EVIL. It fundamentally breaks > the notion of "grep for usage" by introducing two names to the > same thing, without having even a good reason (ie no "nice > abstraction" thing or anything).
Right! I fully agree that having 2 names for the same type is bad, although "find -type f | grep flavou?r" would be a quite adequate way of matching both spellings.
The point is, though, that I could have written
rpc_authflavor_t f;
and nobody would have cared or complained about grepability.
Anybody who claims that they have problems reading the code due to the difference between US and British spelling of the same variable is in reality engaged in a completely different type of crusade. One that doesn't deserve attention...
Cheers, Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |