lkml.org 
[lkml]   [2003]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][TRIVIAL] Bugzilla bug # 322 - double logical operator drivers/char/sx.c
From
Date
Josef 'Jeff' Sipek <jeffpc@optonline.net> writes:

> Just a simple fix to make the statements more readable. (instead of
> "i < TIMEOUT > 0" the statement is divided into two, joined by &&.)
>
> Josef 'Jeff' Sipek
>
> --- linux-2.5/drivers/char/sx.c.orig 2003-08-06 18:23:32.000000000 -0400
> +++ linux-2.5/drivers/char/sx.c 2003-08-06 18:20:03.000000000 -0400
> @@ -511,13 +511,13 @@
>
> func_enter ();
>
> - for (i=0; i < TIMEOUT_1 > 0;i++)
> + for (i=0; (i < TIMEOUT_1) && (TIMEOUT_1 > 0);i++)
> if ((read_sx_byte (board, offset) & mask) == correctval) {
> func_exit ();
> return 1;
> }
>

While the first version seems to be a notation error (i < X > 0 is
equivalent to i < X) the changed version doesn't need X > 0 either
as TIMEOUT_1 (and TIMEOUT_2 respectively) is a positive #define.
So I think it should be just (i=0; i < TIMEOUT_1 ;i++) and so on.
--
Krzysztof Halasa
Network Administrator
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:47    [from the cache]
©2003-2011 Jasper Spaans