lkml.org 
[lkml]   [2003]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: IDE locking problem

    On 3 Aug 2003, Benjamin Herrenschmidt wrote:

    > And there's more to it... ide_unregister() doesn't copy hwif->hold from
    > old to new hwif causing my hotswap bay to lose it's iops on next plug,
    > it doesn't call unregister_device() for neither hwif->gendev nor
    > drive[n]->gendev, causing the device model list to be corrupted after
    > an unregister, ...

    What is a goal of calling init_hwif_data() in ide_unregister()?
    I guess it is used mainly to clear hwif->io_ports and hwif->irq.
    Therefore even if you are using hwif->hold flag io_ports will be set to
    default values, so how do you later find your hwif?

    Hmmm... what about not copying anything and calling init_hwif_data()
    only if !hwif->hold?

    --
    Bartlomiej

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:47    [W:0.020 / U:127.888 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site