lkml.org 
[lkml]   [2003]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] s390 (5/8): common i/o layer.
On Fri, Aug 29, 2003 at 11:06:18PM +0200, Arnd Bergmann wrote:
> On Friday 29 August 2003 22:50, Greg KH wrote:
> > diff -Nru a/drivers/usb/core/file.c b/drivers/usb/core/file.c
> > --- a/drivers/usb/core/file.c Fri Aug 29 13:49:19 2003
> > +++ b/drivers/usb/core/file.c Fri Aug 29 13:49:20 2003
> > @@ -129,7 +129,7 @@
> > int retval = -EINVAL;
> > int minor_base = class_driver->minor_base;
> > int minor = 0;
> > - char name[DEVICE_ID_SIZE];
> > + char name[BUS_ID_SIZE];
> > struct class_device *class_dev;
> > char *temp;
> >
>
> In your case, BUS_ID_SIZE doesn't look appropriate here either, because
> the name is never used directly as a bus_id. You should probably use
> your own constant here.

Look a little lower and see where I copy that name into a struct
class_device.class_id, which is BUS_ID_SIZE big :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site