Messages in this thread Patch in this message | | | Subject | Re: 2.6.0-test4-mm3 | From | Valdis.Kletnieks@vt ... | Date | Fri, 29 Aug 2003 12:22:26 -0400 |
| |
On Fri, 29 Aug 2003 08:35:40 PDT, Andrew Morton said:
> Meanwhile, I'll alter Valdis's patch so that it warns, but does not fail > the make. >
I've sent Andrew an updated patch (attached) which issues a warning if the final depmod actually fails. The user won't know there's a problem till the very end of 'make modules_install', but at least it will give them a hint of where to go for self-help.
--- Makefile.hold 2003-08-27 01:52:20.000000000 -0400 +++ Makefile 2003-08-29 11:52:15.542286300 -0400 @@ -209,7 +209,7 @@ RPM := $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo rpmbuild; \ else echo rpm; fi) GENKSYMS = scripts/genksyms/genksyms -DEPMOD = /sbin/depmod +DEPMOD = /sbin/depmod.old KALLSYMS = scripts/kallsyms PERL = perl CHECK = sparse @@ -612,7 +612,14 @@ endif .PHONY: _modinst_post _modinst_post: _modinst_ - if [ -r System.map ]; then $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE); fi + @if [ -r System.map ]; then \ + if ! $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE) ; then \ + echo "*** Depmod failed!!!"; \ + echo "*** You may need to install a current version of module-init-tools"; \ + echo "*** See http://www.codemonkey.org.uk/post-halloween-2.5.txt"; \ + exit 1; \ + fi \ + fi else # CONFIG_MODULES
[unhandled content-type:application/pgp-signature] | |