Messages in this thread |  | | | Date | Mon, 25 Aug 2003 19:02:50 +0200 | | From | Jörn Engel <> | | Subject | Re: [BK PATCH] One strdup() to rule them all |
| |
On Mon, 25 August 2003 19:55:12 +0300, Dan Aloni wrote: > > > > My gut feeling is always afraid when something "must not be NULL", > > someone will ignore this and Bad Things (tm) happen. Is strdup ever > > used such performance critical code that the extra check would hurt? > > There are two reasons while it shouldn't have a NULL check. One, > persistency: the other str*() functions don't do this sort of check. > Two, for general uses like that: > > new_name = strdup(name); > if (!new_name) > goto allocation_failed; > > With this check, NULL would be returning from strdup() either because > name == NULL or when the allocation fails.
True, I missed that one.
> Passing NULL to strdup() is a bug, which would have NOT show as an > Oops if you add this check, and that is bad. Maybe it would be worth > to add a BUG_ON(s == NULL) instead, and perhaps also add this to the > other str*() functions, but that is a different patch.
Ok. Will you write that patch then or do I have to put it onto my list?
Jörn
-- When in doubt, use brute force. -- Ken Thompson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |