Messages in this thread | | | Date | Sat, 23 Aug 2003 00:10:25 +0200 | From | Pavel Machek <> | Subject | Re: [PM] Patrick: which part of "maintainer" and "peer review" needs explaining to you? |
| |
Hi!
> > static int __init resume_setup(char *str) > > { > > - strncpy( resume_file, str, 255 ); > > + if (strlen(str)) > > + strncpy(resume_file, str, 255); > > return 1; > > } > > > > Why are you obfuscating the code? > > Eh? First, why would you want to copy a NULL string?
How is strlen(NULL) better than strncpy(_, NULL, _)? Pavel
-- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |