Messages in this thread | | | Date | Wed, 20 Aug 2003 10:48:31 -0700 | From | "David S. Miller" <> | Subject | Re: [2.4 PATCH] bugfix: ARP respond on all devices |
| |
On Wed, 20 Aug 2003 10:44:41 -0700 Ben Greear <greearb@candelatech.com> wrote:
> It seems that these reasons would not preclude the addition of a flag > that would default to the current behaviour but allow the behaviour that > other setups desire easily?
I would accept a patch that did something like the following in arp_solicit().
if (skb && inet_addr_type(skb->nh.iph->saddr) == RTN_LOCAL && (in_dev->conf.shared_media || inet_addr_onlink(dev, skb->nh.iph->saddr, 0))) saddr = skb->nh.iph->saddr; else saddr = inet_select_addr(dev, target, RT_SCOPE_LINE);
Then people can frob the shared_media sysctl for devices where they want the behavior to be that we will only use addresses assigned to the device as the solicitor address.
The shared_media setting defaults to one and thus would preserve current behavior by default.
The idea is not mine, Alexey suggested it to me the other day.
I hope this pleases people wrt. ARP request solicitor address handling. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |