lkml.org 
[lkml]   [2003]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] RFC: kills consistent_dma_mask
    From
    Date
    >>>>> "Krzysztof" == Krzysztof Halasa <khc@pm.waw.pl> writes:

    Krzysztof> Example:

    Krzysztof> $ grep DMA_MASK sound/oss/emu10k1/main.c #define
    Krzysztof> EMU10K1_DMA_MASK 0x1fffffff /* DMA buffer mask for
    Krzysztof> pci_alloc_consist */ if (pci_set_dma_mask(pci_dev,
    Krzysztof> EMU10K1_DMA_MASK)) {

    Krzysztof> Do you see a problem here? It will work if and only if
    Krzysztof> pci_alloc_consistent uses dma_mask rather than
    Krzysztof> consistent_dma_mask.

    Yes there is a problem, them emu10k driver was expecting the
    pci_set_dma_mask call to affect pci_alloc_consistent, which was
    unfortunately incorrect usage of the API.

    Jes
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:47    [W:4.428 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site