Messages in this thread | | | Subject | Re: [PATCH] RFC: kills consistent_dma_mask | From | Jes Sorensen <> | Date | 19 Aug 2003 05:24:11 -0400 |
| |
>>>>> "Krzysztof" == Krzysztof Halasa <khc@pm.waw.pl> writes:
Krzysztof> Example:
Krzysztof> $ grep DMA_MASK sound/oss/emu10k1/main.c #define Krzysztof> EMU10K1_DMA_MASK 0x1fffffff /* DMA buffer mask for Krzysztof> pci_alloc_consist */ if (pci_set_dma_mask(pci_dev, Krzysztof> EMU10K1_DMA_MASK)) {
Krzysztof> Do you see a problem here? It will work if and only if Krzysztof> pci_alloc_consistent uses dma_mask rather than Krzysztof> consistent_dma_mask.
Yes there is a problem, them emu10k driver was expecting the pci_set_dma_mask call to affect pci_alloc_consistent, which was unfortunately incorrect usage of the API.
Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |