lkml.org 
[lkml]   [2003]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: Input issues - key down with no key up
    On Tuesday August 19, vojtech@suse.cz wrote:
    > > It behaved REALLY strangly until I fixed these typoes:
    > >
    > > > + mod_timer(&atkbd->timer,
    > > > + (test_bit(atkbd->keycode[code], &atkbd->dev.key)
    > > > + ? HZ/30 : HZ/4) + HZ/100);
    > >
    > > should be
    > >
    > > > + mod_timer(&atkbd->timer, jiffies +
    > > > + (test_bit(atkbd->keycode[code], atkbd->dev.key)
    > > > + ? HZ/30 : HZ/4) + HZ/100);
    >
    > Thanks for spotting that! I originally had "!test_bit" there, and then
    > removed the ! and forgot to swap the conditional values.

    I swapped the "30" and the "4", it is is better still. Auto-repeat of
    normal keys is ok (I think - didn't test extensively).
    control/shift is still a problem, though not quite as a bad

    When I hold right-control down, evtest shows:

    Event: time 1061335715.975639, type 1 (Key), code 97 (RightCtrl), value 1
    Event: time 1061335715.975639, -------------- Config Sync ------------
    Event: time 1061335716.014658, type 1 (Key), code 97 (RightCtrl), value 0
    Event: time 1061335716.014659, -------------- Config Sync ------------
    Event: time 1061335716.485899, type 1 (Key), code 97 (RightCtrl), value 1
    Event: time 1061335716.485899, -------------- Config Sync ------------
    Event: time 1061335716.734535, type 1 (Key), code 97 (RightCtrl), value 2
    Event: time 1061335716.734536, -------------- Config Sync ------------
    Event: time 1061335716.764555, type 1 (Key), code 97 (RightCtrl), value 2
    Event: time 1061335716.764556, -------------- Config Sync ------------

    so if I type another char between 30ms and 500ms after pressing
    control, the control isn't noticed, else it is.

    NeilBrown
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:47    [W:0.022 / U:60.688 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site