Messages in this thread | | | Subject | Re: [PATCH] Ratelimit SO_BSDCOMPAT warnings | From | Valdis.Kletnieks@vt ... | Date | Mon, 18 Aug 2003 18:15:40 -0400 |
| |
On Mon, 18 Aug 2003 15:06:05 PDT, Phil Oester said: > Back in March, there was some discussion about ratelimiting the > BSDCOMPAT errors, and James Morris provided a patch to achieve > this.
> Unfortunately, it seems to have fallen through the cracks. Below > is the patch again, updated for 2.6.0-test3 - please apply.
> static void sock_warn_obsolete_bsdism(const char *name) > { > - printk(KERN_WARNING "process `%s' is using obsolete " > - "%s SO_BSDCOMPAT\n", current->comm, name); > + static int warned; > + > + if (!warned) { > + warned = 1;
Umm.. am I dense, or does this only warn once for *the first program* to do it after the system boots? And you don't get another warning about any OTHER programs until you reboot in a few weeks (possibly)?
If so, why are we bothering at all? Once *per process* I could see, but once per boot? [unhandled content-type:application/pgp-signature] | |