Messages in this thread | | | From | Denis Vlasenko <> | Subject | Re: [PATCH] Inline vfat_strnicmp() | Date | Fri, 1 Aug 2003 08:55:48 +0300 |
| |
On 31 July 2003 18:07, OGAWA Hirofumi wrote: > Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> writes: > > > Yes, but some future version would. > > > > Since there is no substantial wins in hunting down > > such statics, and there is some risk of code bloat when > > big inlined statics get called from more that one callsite, > > and it will be automatically handled by smarter compiler someday, > > I think it makes perfect sense to avoid doing this. > > Could you tell me, if compiler does it in future? I'll gladly kill > that inline.
I can't be 100.00% sure it will happen. I'd say 98.234235% ;)
Andrew Morton kills extra large inlines, and you are creating them :( That's not ok. Just leave those poor static functions alone until compiler will do them, all at once. There are lots of other stuff to do in the kernel source. -- vda - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |