Messages in this thread | | | Date | Fri, 1 Aug 2003 08:23:26 +0200 (CEST) | From | Ingo Molnar <> | Subject | Re: PATCH: Race in 2.6.0-test2 timer code |
| |
On Thu, 31 Jul 2003 linas@austin.ibm.com wrote:
> Well, I'm confused by this a bit too, now. I saw this bug in 2.4 and I > thought that Andrea was implying that it couldn't happen in 2.6. He > seemed to be saying that the del_timer_sync() + add_timer() race can > happen only in 2.4, where add_timer() is running on the 'wrong' cpu > bacuase it got there through the evil run_all_timers()/TIMER_BH. Since > there's no run_all_timers() in 2.6, he seemed to imply that the race > 'couldn't happen'. Is he right?
it is correct, but it was me convincing Andrea about this, not the other way around :-) Pls. re-read the email thread. My point still stands:
>> (in any case, i still think it would be safer to 'upgrade' the >> add_timer() interface to be SMP-safe and to allow double-adds - but not >> for any bug reason anymore.)
this should also make backporting easier.
Ingo
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |