lkml.org 
[lkml]   [2003]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] do_generic_direct_write: bad flag check


Marcelo Tosatti wrote:

>
> On Thu, 10 Jul 2003, J.A. Magallon wrote:
>
>
>>On 07.10, Marcelo Tosatti wrote:
>>
>>>Hi,
>>>
>>>Here goes -pre4. It contains a lot of updates and fixes.
>>>
>>
>>--- linux-2.4.22-pre2-jam1/mm/filemap.c.orig 2003-06-28 01:55:36.000000000 +0200
>>+++ linux-2.4.22-pre2-jam1/mm/filemap.c 2003-06-28 01:55:45.000000000 +0200
>>@@ -3223,7 +3223,7 @@
>> if (err != 0 || count == 0)
>> goto out;
>>
>>- if (!file->f_flags & O_DIRECT)
>>+ if (!(file->f_flags & O_DIRECT))
>> BUG();
>>
>> remove_suid(inode);
>>
>>...but sure the fix in -ac is better.
>
>
> What is the difference between the fix in -ac and yours?

There's a difference?? Looks the same to me. Unless there is part of
the patch we don't see.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:46    [W:0.048 / U:0.436 seconds]
©2003-2014 Jasper Spaans. Advertise on this site