Messages in this thread | | | Date | Thu, 10 Jul 2003 01:07:54 +0200 | From | "J.A. Magallon" <> | Subject | Re: [PATCH] 2.4.22-pre3: P3 and P4 for chekc_gcc |
| |
On 07.10, Jeff Garzik wrote: > J.A. Magallon wrote: > > --- linux-2.4.21-bp1/arch/i386/Makefile.orig 2003-06-18 23:40:25.000000000 +0200 > > +++ linux-2.4.21-bp1/arch/i386/Makefile 2003-06-18 23:59:25.000000000 +0200 > > @@ -53,11 +53,11 @@ > > endif > > > > ifdef CONFIG_MPENTIUMIII > > -CFLAGS += -march=i686 > > +CFLAGS += $(call check_gcc,-march=pentium3,-march=i686) > > endif > > > > ifdef CONFIG_MPENTIUM4 > > -CFLAGS += -march=i686 > > +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686) > > endif > > > Looks ok to me (I run this patch locally, and also am the one who > submitted the check_gcc patch). > > I haven't had any problems at all, but I'm curious if anyone has any > negative feedback... It's rather easy to be conservative and ignore the > patch, since -march=i686 should always work. >
Just curious, what can go wrong ? Only if gcc has a bug when scheduling insns for P4, for example, or if gcc spits some special that does not work as supposed...
-- J.A. Magallon <jamagallon@able.es> \ Software is like sex: werewolf.able.es \ It's better when it's free Mandrake Linux release 9.2 (Cooker) for i586 Linux 2.4.22-pre2-jam1 (gcc 3.3 (Mandrake Linux 9.2 3.3-2mdk)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |