[lkml]   [2003]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] [7/6] PCI config space in sysfs
On Thu, Jul 03, 2003 at 09:42:58PM +0100, Matthew Wilcox wrote:
> - Fix a couple of bugs in sysfs's handling of binary files (my fault).

Now I'm having second thoughts. Sigh ;-)

My intended design was that sysfs would copy to/from buffer + offset
rather than buffer. Seems that change 1.6 to this file (hm, bkweb seems
broken at the moment?) changed that. so that broke my pci-sysfs changes
which weren't in the tree at the time.

It probably makes more sense to copy to/from buffer rather than
buffer+offset so we can implement larger sized binary files (we can use
a smaller buffer than the size of the file and do multiple read/write

So I think I'd like to hold off on this patchset, not change sysfs and
adapt my changes to the new API (which I didn't even know had changed.

"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:46    [W:0.042 / U:15.812 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site