Messages in this thread | | | Date | Tue, 29 Jul 2003 19:57:04 +0200 | From | Manfred Spraul <> | Subject | Re: [PATCH] select fix |
| |
Andrew Morton wrote:
>Andries.Brouwer@cwi.nl wrote: > > >>- if (tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS) >>+ if (!tty->stopped && tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS) >> mask |= POLLOUT | POLLWRNORM; >> >> > >Manfred sent a patch through esterday which addresses it this way: > >- if (tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS) >+ if (tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS && >+ tty->driver->write_room(tty) > 0) > >Any preferences? > > Who should implement tty->stopped? AFAICS tty->stopped is implemented in the drivers right now, and my patch would leave that unchanged.
-- Manfred
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |