lkml.org 
[lkml]   [2003]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: Linux 2.4.22-pre8
Date
Hello Geert and Marcelo,

it turns oout that the warning is bogus, and trivially fixed. Marcelo, you may
want to apply the attached patch.

Cheers,
Andreas.

On Friday 25 July 2003 03:05, Geert Uytterhoeven wrote:
> On Thu, 24 Jul 2003, Marcelo Tosatti wrote:
> > Andreas Gruenbacher:
> > o unshare-files fix breaks file locks
>
> Which adds one more warning (the third one below) to my build log:
> | ide.c:175: warning: `ide_scan_direction' defined but not used
> | ide-lib.c:174: warning: comparison of distinct pointer types lacks a cast
> | binfmt_elf.c:446: warning: `files' might be used uninitialized in this
> | function
>
> Seems to be harmless, though.
--- linux-2.4.22-pre8.orig/fs/binfmt_elf.c 2003-07-25 08:58:59.000000000 +0200
+++ linux-2.4.22-pre8/fs/binfmt_elf.c 2003-07-25 08:59:07.000000000 +0200
@@ -797,10 +797,8 @@
if (current->ptrace & PT_PTRACED)
send_sig(SIGTRAP, current, 0);
retval = 0;
+ steal_locks(files, current->files);
out:
- if (!retval)
- steal_locks(files, current->files);
-
return retval;

/* error cleanup */
\
 
 \ /
  Last update: 2005-03-22 13:47    [W:0.092 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site