Messages in this thread | | | Subject | Re: [PATCH] Washing suspend code | From | David Woodhouse <> | Date | Mon, 21 Jul 2003 03:55:30 +0100 |
| |
On Wed, 2003-07-02 at 14:10, Dave Jones wrote: > On Wed, Jul 02, 2003 at 10:43:11AM +0200, ffrederick@prov-liege.be wrote: > > } > > +int touchable_process (struct task_struct *p) > > +{ > > + return(!((p->flags & PF_IOTHREAD) || (p == current) || (p->state == TASK_ZOMBIE))) > > + > > +} > > *horror*. Please keep the formatting of the original macro. > It's a) more readable, and b) Documentation/CodingStyle compliant.
Bugger the formatting. The original macro invocation 'INTERESTING(p)' may invoke 'continue;' and change the flow of execution in an utterly unobvious manner. The 'if (something) continue;' form is _definitely_ better.
-- dwmw2
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |