lkml.org 
[lkml]   [2003]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: POLLRDONCE optimisation for epoll users (was: epoll and half closed TCP connections)
Davide Libenzi wrote:
> > > Where this will break by using a POLLRDHUP ?
> >
> > It will break if
> >
> > (a) fd isn't a socket
> > (b) fd isn't a TCP socket
> > (c) kernel version <= 2.5.75
> > (d) SO_RCVLOWAT < s
> > (e) there is urgent data with OOBINLINE (I think)

> Jamie, did you smoke that stuff again ? :)
> With Eric patch in the proper places it is just fine. You just make
> f_op->poll() to report the extra flag other that POLLIN. What's the problem ?

The problem in cases (a)-(e) is your loop will call read() just once
when it needs to call read() until it sees EAGAIN.

What's wrong is the behaviour of your program when the extra flag
_isn't_ set.

-- Jamie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:46    [W:0.099 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site