Messages in this thread Patch in this message | | | Date | Sat, 12 Jul 2003 07:49:19 -0600 (MDT) | From | James Bourne <> | Subject | linux-2.4.22-pre5 drm/agpsupport unresolved symbols (fwd) |
| |
[And now for the patch, sorry forgot to attach it... *sigh*]
The attached patch fixes the following compile error when building agpsupport as a module. This is against 2.4.22pre5.
Marcelo, please apply as it's a very simple patch the adds the symbol to an enum in include/linux/agp_backend.h and adds a missed break statement in drm-4.0/agpsupport.c.
********** gcc -D__KERNEL__ -I/usr/src/redhat/BUILD/kernel-2.4.22pre5/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -DMODULE -DMODVERSIONS -include /usr/src/redhat/BUILD/kernel-2.4.22pre5/include/linux/modversions.h -nostdinc -iwithprefix include -DKBUILD_BASENAME=agpsupport -c -o agpsupport.o agpsupport.c agpsupport.c: In function `drm_agp_bind': agpsupport.c:215: warning: concatenation of string literals with __FUNCTION__ is deprecated agpsupport.c: In function `drm_agp_init': agpsupport.c:280: `VIA_APOLLO_P4X400' undeclared (first use in this function) agpsupport.c:280: (Each undeclared identifier is reported only once agpsupport.c:280: for each function it appears in.) make[3]: *** [agpsupport.o] Error 1 make[3]: Leaving directory `/usr/src/redhat/BUILD/kernel-2.4.22pre5/drivers/char/drm-4.0' make[2]: *** [_modsubdir_drm-4.0] Error 2 make[2]: Leaving directory `/usr/src/redhat/BUILD/kernel-2.4.22pre5/drivers/char' make[1]: *** [_modsubdir_char] Error 2 make[1]: Leaving directory `/usr/src/redhat/BUILD/kernel-2.4.22pre5/drivers' make: *** [_mod_drivers] Error 2 ******************
Thanks and regards James Bourne
-- James Bourne | Email: jbourne@hardrock.org Unix Systems Administrator | WWW: http://www.hardrock.org Custom Unix Programming | Linux: The choice of a GNU generation ---------------------------------------------------------------------- "All you need's an occasional kick in the philosophy." Frank Herbert
--- linux-2.4.22pre5/include/linux/agp_backend.h~ 2003-07-12 14:36:54.000000000 +0700 +++ linux-2.4.22pre5/include/linux/agp_backend.h 2003-07-12 14:36:54.000000000 +0700 @@ -66,6 +66,7 @@ VIA_APOLLO_KM266, VIA_APOLLO_KT400, VIA_APOLLO_P4M266, + VIA_APOLLO_P4X400, SIS_GENERIC, AMD_GENERIC, AMD_IRONGATE, --- linux-2.4.22pre5/drivers/char/drm-4.0/agpsupport.c~ 2003-07-12 14:36:59.000000000 +0700 +++ linux-2.4.22pre5/drivers/char/drm-4.0/agpsupport.c 2003-07-12 14:36:59.000000000 +0700 @@ -278,6 +278,7 @@ case VIA_APOLLO_KT400: head->chipset = "VIA Apollo KT400"; break; case VIA_APOLLO_P4X400: head->chipset = "VIA Apollo P4X400"; + break; #endif case VIA_APOLLO_PRO: head->chipset = "VIA Apollo Pro"; | |