Messages in this thread | | | Date | Mon, 9 Jun 2003 14:42:42 +0400 | From | Ivan Kokshaysky <> | Subject | Re: [PATCH] [3/3] PCI segment support |
| |
On Mon, Jun 09, 2003 at 03:20:56AM -0700, David S. Miller wrote: > On Mon, 2003-06-09 at 03:07, Ivan Kokshaysky wrote: > > Looks good, but shouldn't we pass 'struct pci_bus *' instead > > of pci_dev to pci_domain_nr()? > > I don't think it matters, but someone may find a useful > use of having the exact device available, who knows...
Hmm. Actually the patch *does* use pci_bus. What got me confused is definition in include/linux/pci.h:
+#ifndef CONFIG_PCI_DOMAINS +#define pci_domain_nr(pdev) 0 ~~~~ +#endif
I think it should be changed to 'pbus' to avoid confusion.
> We could just pass the bus self device in this case.
Root buses often do not have the self device, e.g. on alpha.
Ivan. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |