lkml.org 
[lkml]   [2003]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][ATM] use rtnl_{lock,unlock} during device operations (take 2)
Hi,

On Sat, 7 Jun 2003, David S. Miller wrote:

> The basic problem is still that module_exit is a synchronous interface,
> from where you can't call any asynchronous functions, unless you prevent
> new callbacks via try_module_get() or you have to wait for all pending
> events.
>
> We don't use module refcounts at all anymore for netdev objects.
> That's the whole key.

If I read the source correctly, unregister_netdevice() simply does rip the
device out and sees what happens? It's a bit primitive, but should of
course work too.
I'm just not sure if that model works that well in other parts too, I
think file systems don't really like it, if the device under them
disappears. Any kind of automatic module unloading also becomes a bit
difficult without a module use count. I also hope no net driver starts
exporting it's own data via sysfs (I currently don't see anything that
would protect this).
BTW does anything protect the get_stats() call in netstat_attr_show()?

bye, Roman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.066 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site